Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Meta header for propagators #122

Merged
merged 8 commits into from
Nov 20, 2024
Merged

MAINT: Meta header for propagators #122

merged 8 commits into from
Nov 20, 2024

Conversation

jklenzing
Copy link
Member

Description

Adds orbital info used for propagation to global metadata values. If Keplerian elements are used in generation, then only those elements (including default values) are added. If TLEs are used, only those default values are used.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Loading an instrument and inspecting for header data.

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes
  • Update zenodo.json file for new code contributors

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@jklenzing jklenzing requested a review from aburrell November 20, 2024 17:59
Copy link
Member

@aburrell aburrell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Style suggestion for legibility.

Co-authored-by: Angeline Burrell <[email protected]>
@aburrell
Copy link
Member

@jklenzing I approved, but just noticed that 3.10 is failing. :( Up to you on solving that.

@jklenzing
Copy link
Member Author

@jklenzing I approved, but just noticed that 3.10 is failing. :( Up to you on solving that.

It's related to apexpy. Will probably just turn that bit off.

@jklenzing
Copy link
Member Author

apexpy is only installed for the older numpy. This was implemented in the previous version due to poor compatibility with numpy 2.0.0. Since this is optional, other workflows skip over apexpy-related tests.

Bumping our minimum numpy to match SPEC 0 (1.23 -> 1.24) seems to fix the issue for now.

@jklenzing jklenzing merged commit 882b59b into develop Nov 20, 2024
19 checks passed
@jklenzing jklenzing deleted the maint/meta_header branch November 20, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants