-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: SSUSI bug and function deprecation #170
Conversation
There are dimensions that are not always present in the SSUSI data, and so this kwarg must be False.
Added a deprecation warning to `expand_coords` and filtered in in the local calls so that users are only warned when they call the function directly.
Added a unit test for the new deprecation warning.
Updated the changelog.
Fixed issues revealed by CI flake8.
Failing due to issues addressed in #129, I believe. |
Added a catch for missing metadata when determining the fill value.
Added a missing variable to the full call.
Since SSUSI data has not yet been released, do we need to deprecate the code? The next release here will be after pysat 3.1.0 and have that as a minimum req. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Verified that dmsp ssusi / timed guvi not present in last released version. Deprecation not needed since these functions have not yet been released, unless we are being super thorough.
Merging develop back into this should fix the setup issues.
Develop update for SSUSI
Removed the local `expand_coords` function and replaced it with the new pysat `expand_xarray_dims` function.
Removed the deprecation tests, as they are no longer needed.
Removed deprecation warning from the changelog.
…into ssusi_bug_w_dep
Waiting on pysat/pysat#1116 and pysat/pysat#1123 before tests will pass. |
Re-running with pysat 3.1.0, we get
for the timed saber data. This appears in the other pull too, so something probably changed with expand_dims. Or possibly there's another update I haven't seen yet |
Found the bug, it was in issue with TIMED SABER revealed by the new |
Merging in the recent changes from |
Develop update to SSUSI bug
Description
Fixes a bug identified when running several years of SSUSI data that revealed the dimensions sometimes change. Also deprecated a function introduced to pysat from this package, partially addressing issue #169.
Type of change
Please delete options that are not relevant.
Breaking change (fix or feature that would cause existing functionalityto not work as expected)How Has This Been Tested?
Added a unit test and also loaded a year of data (2010, one day at a time) for F16.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes