-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: TIMED SABER and xarray #175
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Additional meta header issues out of scope, documented as #176 |
This should fix the issues seen in the other PRs |
aburrell
reviewed
Jun 1, 2023
Co-authored-by: Angeline Burrell <[email protected]>
aburrell
approved these changes
Jun 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses #174
TIMED SABER has an extra variable for time, for use with the tpaltitude profiles. This means that 'Epoch' will not be renamed 'time', breaking the new expand_dims code in pysat 3.1.0.
BONUS BUG: when multiple xarray files are combined via
xr.combine_nested
, the attrs for each variable are dropped, meaning that meta is not set for each variable.xr.combine_nested
now uses the kwargcombine_attrs='override'
to use the attrs from the first file.use_cdflib=True
for xarray objects to suppress warning message. pysatCDF does not currently support xarray, so this can be hard wiredType of change
How Has This Been Tested?
Loading a day of data and inspecting the metadata.
Test Configuration
Checklist:
develop
(notmain
) branchCHANGELOG.md
, summarizing the changes