Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Remove use of label kwarg #136

Closed
aburrell opened this issue Jan 16, 2024 · 0 comments · Fixed by #148
Closed

MAINT: Remove use of label kwarg #136

aburrell opened this issue Jan 16, 2024 · 0 comments · Fixed by #148
Milestone

Comments

@aburrell
Copy link
Member

Description

After pysat 3.2.0 is the latest supported version of pysat, the label Instrument kwarg will no longer need to be supported.

Potential impact

  • Is the feature related to an existing problem? Some support methods use the label kwarg, which has been deprecated
  • How critical is this feature to your workflow? Important for maintanability
  • How wide of an impact to you anticipate this enhancement having? Important for developers
  • Would this break any existing functionality? No

Potential solution(s)

Identify places in the code where a pysat Instrument is called using labels and replace with meta_kwargs.

Alternatives

Continue to support kwargs of no-longer-supported pysat versions

@aburrell aburrell added this to the 1.0.0 milestone Jan 16, 2024
@aburrell aburrell modified the milestones: 1.0.0, 0.2.0 Feb 15, 2024
@aburrell aburrell linked a pull request Aug 14, 2024 that will close this issue
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant