Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Maintenance for V0.2.0 release #148

Merged
merged 9 commits into from
Aug 15, 2024
Merged

Maintenance for V0.2.0 release #148

merged 9 commits into from
Aug 15, 2024

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Aug 14, 2024

Description

Addresses #136, #131, and #101 by removing support for deprecated features and updating the minimum supported pysat version to 3.2.0+.

Type of change

Please delete options that are not relevant.

  • Breaking change (fix or feature that would cause existing functionality
    to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Ran unit tests locally

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.10
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Removed support for the deprecated GFZ dataset with tag ''.
Removed the test for the deprecation warning.
Removed support in the Kp methods for the '' tag, which was removed.
Updated the minimum supported pysat version to 3.2.0.
Removed support for older pysat versions, notably the 'use_header' kwarg.
Updated the F10.7 method functions to not support older versions of pysat, notably using the 'use_header' kwarg.
Transitioned to `meta_kwargs` with the update to not support older pysat versions.
Updated maintenance log.
Removed the warnings module.
@aburrell
Copy link
Member Author

@jklenzing expect this is the time of day failure, as it's the same files as yesterday. Will re-run the tests in a bit.

@aburrell aburrell requested a review from jklenzing August 14, 2024 21:47
@aburrell aburrell merged commit f1cd6b1 into develop Aug 15, 2024
28 of 30 checks passed
@aburrell aburrell deleted the v0.2.0_maint branch August 15, 2024 14:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: Remove use of label kwarg MAINT: Remove use_header kwarg MAINT: remove deprecated kp tag: ''
2 participants