Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: avoid certificate experation #144

Merged
merged 31 commits into from
Aug 14, 2024
Merged

BUG: avoid certificate experation #144

merged 31 commits into from
Aug 14, 2024

Conversation

aburrell
Copy link
Member

Avoid certificate expiration by using the verify flag set to False.

Addresses an issue identified at APL, where their certificate had expired.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Unit tests

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.10
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

@aburrell
BUG: avoid certificate experation
916dc29 
Avoid certificate expiration by using the `verify` flag set to False.
@aburrell
Copy link
Member Author

aburrell commented Jul 30, 2024 •
edited
Loading

  • fix broken links
  • update intersphinx mapping
  • fix whatever is up with the GA tests

aburrell added 25 commits August 12, 2024 17:16
@aburrell
MAINT: updated pandas fill method in f107
f0995e2 
Updated the pandas fill method, replacing the deprecated `fillna` with `ffill`.
@aburrell
MAINT: updated pandas in kp_ap
bd271fe 
Updated the pandas indexing and fill method, replacing the deprecated `fillna` with `ffill`.
@aburrell
STY: added logger output
d86c91a 
Added logger output for file creation at the info level.
@aburrell
MAINT: updated pandas in sw_f107
068da4b 
Updated the pandas series indexing method.
@aburrell
DOC: updated NCEI name
4b9c8c8 
Updated the NCEI name.  Did not add a link, as their website is not stable.
@aburrell
DOC: added links to ignore
445f7f8 
Added links to ignore in the unit tests, as they are file but require certificates to access.
@aburrell
DOC: update summary of changes
6d375fe 
Updated changelog.
@aburrell
MAINT: updated intersphinx mapping
d042597 
Updated intersphinx mapping.
@aburrell
MAINT: cycled python versions
e1b5e25 
Removed Python 3.9 from listed support.
@aburrell
MAINT: updated main CI test
db19329 
Updated the main CI test by:
- cycling the python versions tested,
- updated NEP29, and
- attempting to use the coveralls action.
@aburrell
BUG: fixed syntax
688135f 
Fixed the syntax for the tuple in the intersphinx mapping.
@aburrell
MAINT: cycle python to highest supported version
756a061 
Cycle the pysat_rc tests to use the highest supported version.
@aburrell
BUG: replaced tab with spaces
ee310e0 
Fixed yaml syntax.
@aburrell
BUG: added token to coveralls action
c6cce4f 
Added the github token secret specification to the coveralls action.
@aburrell
BUG: removed typo
f9353d8 
Removed 's' in call to GitHub Actions.
@aburrell
BUG: change ffill to asfreq
8963895 
The correct change for resampling to maintain the old behaviour was to change `fillna` with `asfreq`.
@aburrell
BUG: fill for sub-daily frequencies
61c5964 
If the frequency is less than a day, use the mean for the entire day.  Otherwise, include a fill value.
@aburrell
TST: allow local testing
a06ebba 
`addopts` was interfering with local testing, move back to test yaml.
@aburrell
BUG: include coveralls in test install
1bf5775 
Probably need coveralls installed to get something to report.
@aburrell
MAINT: updated pandas frequency
c13247c 
Update the format of the pandas frequency to address FutureWarnings.
@aburrell
MAINT: implement pandas iloc
06369e6 
Implement pandas iloc to address FutureWarnings.
@aburrell
TST: ensure output is xml
c2f9f32 
Ensure coveralls output is xml.
@aburrell
BUG: fixed typo
2c5a0ec 
Fixed a typo in the new `iloc` call.
@aburrell
TST: force coveralls to finish
0be7074 
Try and force coveralls to finish even if some jobs fail.
@aburrell
TST: try carryforward
5d5eaa0 
Try carryforward instead of 'fail-on-error'.
@aburrell
Copy link
Member Author

@jklenzing any idea how I can get the coverage analysis to run?

@aburrell
REV: changes were unnecessary
715f315 
Changes were unnecessary, lost track of maintenance updates.
@jklenzing
Copy link
Member

@jklenzing any idea how I can get the coverage analysis to run?

Here's what is working for pysatSeasons: pysat/pysatSeasons#43

@aburrell
TST: added always tag
081d8fc 
Added the "always" yaml call to coveralls.
@aburrell
Merge branch 'kp_verify_bug' of https://github.com/pysat/pysatSpaceWe…
af6f46c 
…ather into kp_verify_bug
@aburrell
TST: remove carryforward
217093b 
Test removing the carryforward command.
@aburrell aburrell requested a review from jklenzing August 13, 2024 19:24
jklenzing
jklenzing requested changes Aug 13, 2024
View reviewed changes
Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make sure the updates to coveralls are included in the pysat_rc.yml

@aburrell
TST: update coveralls
73acafb 
Update coveralls in pysat_rc tests.
@aburrell aburrell requested a review from jklenzing August 13, 2024 23:55
@jklenzing
Copy link
Member

jklenzing commented Aug 14, 2024 •
edited
Loading 

FAILED pysatSpaceWeather/tests/test_instruments.py::TestInstruments::test_load_w_pad[pad0-inst_dict16] - AssertionError: Padding should have left data and didn't
FAILED pysatSpaceWeather/tests/test_instruments.py::TestInstruments::test_load_w_pad[pad0-inst_dict25] - AssertionError: Padding should have left data and didn't
FAILED pysatSpaceWeather/tests/test_instruments.py::TestInstruments::test_load_w_pad[pad1-inst_dict16] - AssertionError: Padding should have left data and didn't
FAILED pysatSpaceWeather/tests/test_instruments.py::TestInstruments::test_load_w_pad[pad1-inst_dict25] - AssertionError: Padding should have left data and didn't

Padding failures in all workflows

@aburrell
Copy link
Member Author

@jklenzing that was an unlucky timing issue with one of the realtime files. Reran tests and now have only expected failures.

@aburrell aburrell merged commit 6786a50 into develop Aug 14, 2024
26 of 30 checks passed
@aburrell aburrell deleted the kp_verify_bug branch August 14, 2024 14:50
@aburrell aburrell added this to the 0.2.0 milestone Aug 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jklenzing jklenzing jklenzing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aburrell @jklenzing