Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Datetime update #145

Merged
merged 4 commits into from
Aug 14, 2024
Merged

Datetime update #145

merged 4 commits into from
Aug 14, 2024

Conversation

aburrell
Copy link
Member

@aburrell aburrell commented Aug 14, 2024

Description

Addresses #143 by replacing utcnow with now calls.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

Ran unit tests locally

Test Configuration

  • Operating system: OS X Big Sur
  • Version number: Python 3.10
  • Any details about your local setup that are relevant: develop branch of pysat

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Removed the deprecated `utcnow` method in the unit tests.
Updated the `utcnow` method call to `now` with the UTC timezone in the instrument methods.
Updated the `utcnow` method call to `now` with the UTC timezone in the instrument submodules.
Added a description of this pull request to the changelog.
@aburrell aburrell added this to the 0.2.0 milestone Aug 14, 2024
@aburrell aburrell linked an issue Aug 14, 2024 that may be closed by this pull request
@aburrell aburrell requested a review from jklenzing August 14, 2024 15:37
@aburrell aburrell merged commit af72bb5 into develop Aug 14, 2024
28 of 30 checks passed
@aburrell aburrell deleted the datetime_update branch August 14, 2024 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MAINT: update datetime
2 participants