Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ops update #152

Merged
merged 5 commits into from
Sep 17, 2024
Merged

Ops update #152

merged 5 commits into from
Sep 17, 2024

Conversation

aburrell
Copy link
Member

Description

Cycles Python support for updated operational environment.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

How Has This Been Tested?

Verified ops configuration.

Test Configuration

  • Operating system: Red Hat
  • Version number: Python 3.9
  • Any details about your local setup that are relevant

Checklist:

  • Make sure you are merging into the develop (not main) branch
  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
  • Add a note to CHANGELOG.md, summarizing the changes

If this is a release PR, replace the first item of the above checklist with the
release checklist on the pysat wiki:
https://github.com/pysat/pysat/wiki/Checklist-for-Release

Update the Ops configuration to use a newer Python version.
Cycle python support to be limited to Python 3.9.
Update the changelog.
Updated the installation instructions to reflect the cycled Python support.
@aburrell aburrell requested a review from jklenzing September 17, 2024 15:00
@aburrell aburrell added this to the 1.0.0 milestone Sep 17, 2024
@jklenzing
Copy link
Member

Are there specific versions of the other scientific python codes (pandas, scipy, xarray) that the new ops environment is running? We may want to use those in addition to numpy.

@aburrell
Copy link
Member Author

aburrell commented Sep 17, 2024 via email

Copy link
Member

@jklenzing jklenzing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't comment directly on the code, but the Install Operational dependencies job in the workflow should be rewritten to look like the NEP29 job:

      run: |
        pip install numpy==${{ matrix.numpy_ver }}
        pip install --upgrade-strategy only-if-needed .[test]

This should fix the install issue that motivated the switch to pyprojecct.

Upgraded the operational installation strategy.
@aburrell aburrell requested a review from jklenzing September 17, 2024 18:15
@aburrell aburrell merged commit a76b22e into develop Sep 17, 2024
31 checks passed
@aburrell aburrell deleted the ops_update branch September 17, 2024 20:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants