Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: fix conflicting path and path ignore #1425

Merged
merged 3 commits into from
Sep 18, 2024
Merged

ci: fix conflicting path and path ignore #1425

merged 3 commits into from
Sep 18, 2024

Conversation

port19x
Copy link
Collaborator

@port19x port19x commented Sep 18, 2024

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@port19x
Copy link
Collaborator Author

port19x commented Sep 18, 2024

Disclaimer: I'm not 100% sure the absolute path /ani-cli is preferred over ani-cli by github actions

@port19x port19x merged commit 353a201 into master Sep 18, 2024
6 checks passed
@port19x port19x deleted the fix_ci branch September 18, 2024 15:57
@port19x
Copy link
Collaborator Author

port19x commented Sep 18, 2024

Let's see if this works

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants