fix: Error logic and updated message and mis-escaped quotes #1434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checks to see if the episode selected is in the list of scraped episodes available for that show and season. Updated error message to reflect result
in pystardust#1391 I used 71zenith's recommendation for fixing quotes escaped. Tested and working with Oshi No Ko's Second season. likely because it's hard to be consistent with the way 「押しの子」is shown in English.
HirschBerge
changed the title
HirschBerge
changed the title
Derisis13
requested changes
Oct 9, 2024
tested working
port19x
reviewed
Oct 10, 2024
port19x
approved these changes
Oct 14, 2024
|
Note I have not done any testing on this PR |
|
@Derisis13 You need to revise your review for this to become mergeable |
|
Thank you both! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks to see if the episode selected is in the list of scraped episodes available for that show and season. Updated error message to reflect result
Pull Request Template
Type of change
Description
Adds additional error messages as discussed in #1429. Previously, any time there was an error, it would always say "Episode not released!" which is not true sometimes. This happens in the case of an episode being released, but not pulling a source correctly (or source not available). This just adds a simple check to see if the $ep_no is in $ep_list. If it is and $episode is empty, it states that the episode is released, but no source available, else, it falls back to the current error message.
While I was here, I implemented 71zenith's suggestion in #1391 to fix issues with specifically Oshi No Ko's second season. It didn't quite work as perfectly as I hoped, so I had to add an extra pipe to remove the literal "'s, but it is tested and working with the above use case.
Sorry for making two unrelated fixes in one PR, I didn't see any guidelines against it though. Please let me know if there are better, or more polished ways to implement my fixes. I'm not as strong in bash as I am some other langs.
Thanks!
Checklist
-chistory and continue work-ddownloads work-ssyncplay works-qquality works-vvlc works-eselect episode works-Sselect index works-rrange selection works--skipani-skip works--skip-titleani-skip title argument works--no-detachno detach works--duband regular (sub) mode both work-hhelp info is up to dateAdditional Testcases