Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add possibility to display rofi menus as normal windows #1481

Merged
merged 8 commits into from
Feb 27, 2025

Conversation

m0squdev
Copy link
Contributor

@m0squdev m0squdev commented Feb 8, 2025

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

On GNOME rofi doesn't receive keyboard input as it is not by default a normal window. Since I'm on Wayland I also tried the rofi-wayland package but it failed to launch because rofi on Wayland requires support for the layer shell protocol. Therefore I decided to implement the option inside ani-cli. The user can add the flag --normal-window (alongside --rofi) to pass -normal-window to rofi. I also added the possibility to set the environment variable ANI_CLI_EXTERNAL_MENU_NORMAL_WINDOW to make it happen always.

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@m0squdev m0squdev closed this Feb 8, 2025
@m0squdev m0squdev reopened this Feb 8, 2025
@port19x
Copy link
Collaborator

port19x commented Feb 26, 2025

I'd prefer if this was just an environment variable and not an option. Its too niche to bloat the help text with it

@port19x port19x changed the title Add possibility to display rofi menus as normal windows feat: add possibility to display rofi menus as normal windows Feb 26, 2025
@port19x port19x merged commit df3e0a9 into pystardust:master Feb 27, 2025
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants