Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: single selection for episode #1492

Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

fix: single selection for episode #1492

wants to merge 5 commits into from

Conversation

71zenith
Copy link
Collaborator

@71zenith 71zenith commented Mar 1, 2025

Pull Request Template

Type of change

  • Bug fix
  • Feature
  • Documentation update

Description

ramble here

Checklist

  • any anime playing
  • bumped version

  • next, prev and replay work
  • -c history and continue work
  • -d downloads work
  • -s syncplay works
  • -q quality works
  • -v vlc works
  • -e select episode works
  • -S select index works
  • -r range selection works
  • --skip ani-skip works
  • --skip-title ani-skip title argument works
  • --no-detach no detach works
  • --dub and regular (sub) mode both work
  • all providers return links (not necessarily on a single anime, use debug mode to confirm)

  • -h help info is up to date
  • Readme is up to date
  • Man page is up to date

Additional Testcases

  • The safe bet: One Piece
  • Episode 0: Saenai Heroine no Sodatekata ♭
  • Unicode: Saenai Heroine no Sodatekata ♭
  • Non-whole episodes: Tensei shitara slime datta ken (ep. 24.5, ep. 24.9)

@71zenith
Copy link
Collaborator Author

71zenith commented Mar 1, 2025

Would like to test it thoroughly this time

@71zenith 71zenith linked an issue Mar 1, 2025 that may be closed by this pull request
@71zenith
Copy link
Collaborator Author

71zenith commented Mar 3, 2025

@port19x if this works, should we do a new release ?

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

@port19x if this works, should we do a new release ?

Yes, that way the thorough testing will actually pay off

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

Note that ani-skip does not work with syncplay

@71zenith
Copy link
Collaborator Author

71zenith commented Mar 3, 2025

if we are doing other changes, please remove the completions section from docs

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

As for providers, testing a dozen anime I can only ever get wixstatic and sharepoint links

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

After now half an hour of exhaustive testing I'm pretty confident in this version aside from the two issues I mentioned.
We can also never be 100% sure about readme instructions for all platforms, but they haven't changed in quite a while, and I can attest to arch and ios working.

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

Using sh -x, I investigated the syncplay ani-skip incompatibility and can conclude its not a limitation on our side.
I opened synacktraa/ani-skip#16

@71zenith
Copy link
Collaborator Author

71zenith commented Mar 3, 2025

As for providers, testing a dozen anime I can only ever get wixstatic and sharepoint links

it looks like most of the original providers are dead. I tested a few and these providers are most consistent.

Ak
Luf-mp4
Luf-Mp4
Yt-mp4
S-mp4

Out of these, we already scrape S-mp4 and Luf-mp4 which are sharepoint and wix respectively.

Correction: I only tested new animes. Some of the old ones also provide Default (which is covered)

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

I tested: one piece, flcl, tsukigakirei, sailor moon, bleach, full metal alchemist brotherhood, banana fish, gintama, dragon ball gt, mushoku tensei

@port19x
Copy link
Collaborator

port19x commented Mar 3, 2025

Sailor moon in particular is prehistoric

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ani-cli autoplays next episode instantly / Ignores download range
2 participants