-
Notifications
You must be signed in to change notification settings - Fork 594
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: single selection for episode #1492
base: master
Are you sure you want to change the base?
Conversation
Would like to test it thoroughly this time |
@port19x if this works, should we do a new release ? |
Yes, that way the thorough testing will actually pay off |
Note that ani-skip does not work with syncplay |
if we are doing other changes, please remove the completions section from docs |
As for providers, testing a dozen anime I can only ever get wixstatic and sharepoint links |
After now half an hour of exhaustive testing I'm pretty confident in this version aside from the two issues I mentioned. |
Using |
it looks like most of the original providers are dead. I tested a few and these providers are most consistent.
Out of these, we already scrape Correction: I only tested new animes. Some of the old ones also provide |
I tested: one piece, flcl, tsukigakirei, sailor moon, bleach, full metal alchemist brotherhood, banana fish, gintama, dragon ball gt, mushoku tensei |
Sailor moon in particular is prehistoric |
Pull Request Template
Type of change
Description
ramble here
Checklist
-c
history and continue work-d
downloads work-s
syncplay works-q
quality works-v
vlc works-e
select episode works-S
select index works-r
range selection works--skip
ani-skip works--skip-title
ani-skip title argument works--no-detach
no detach works--dub
and regular (sub) mode both work-h
help info is up to dateAdditional Testcases