-
Notifications
You must be signed in to change notification settings - Fork 106
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Drop support for EOL Python <= 2.6, 3.0-3.3 #165
Conversation
The Travis CI "runslowtests" job is failing in the same way as master. I've not compared Appveyor, but I see that's also failing on master. |
Any thoughts on merging this? I see #158 added "this library is in maintenance mode and should not be used in new code", and dropping support for EOL Pythons would make that maintenance easier. |
Hi @hugovk sorry for the silence here, thanks for tackling this! We definitely want to merge this; the next pytest release (3.3) already dropped support for Python 2.6 and 3.3. Would you mind rebasing/merging with the latest master? #157 fixed all tests in Linux and Windows so we can then merge this with more confidence. Also, I added an xfail in #157 for 2.6 which we could remove in this PR as well. |
…on 2.6" This reverts commit bdc9112.
@nicoddemus Rebased, and reverted bdc9112! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, thanks! We will have to see how we plan to release this to avoid breaking existing installations
Are we to release 1.5.0 or 2.0 given the fact we are dropping 2.6 and 3.3? We should decide and release pytest-3.2.4 with the appropriate pin, so the next
@RonnyPfannschmidt @The-Compiler @flub @hackebrot @hpk42 what do you guys think? |
@nicoddemus i beleive a 1.5.0 is fine - but we should make a removal note about it (since those are EOL python version i think its fine to expect due diligence from those not fixing that problem) |
Done |
If nobody manifests against it until then, I will open a PR on |
Actually I went ahead and created the PR now: pytest-dev/pytest#2916. We can wait until tomorrow to merge it; if nobody objects, I will merge and get |
Thanks @hugovk again! Now we just need to wait for pytest-3.2.4 to go out before releasing |
'py' 1.5.x dropped support: pytest-dev/py#165 py is a transitive dependency. pip shows low usage: pypa/pip#3796
Fixes #159.