Prevent collection issues with skip statements inside packages #764
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
pytest-asyncio-0.23.4a2 suffers from a problem that causes tests to be skipped during the collection phase as described in
#729 (comment)
It turns out the tests were skipped, because the test suite in question used test packages and the first module inside the package issued a
pytest.skip
statement. The custom collection function for packages introduced in pytest-asyncio-0.23.4a2 tries to accessModule.obj
which triggers thepytest.skip
and causes the collection of the package to abort.Rather than trying to access
Module.obj
, this patch adds a package-scoped fixture to a stack each time a package is collected. The first module inside each package tries to pop an item from the stack and adds the popped loop fixture to itself.