Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default parser switched to cfparse #472

Conversation

elchupanebrej
Copy link

In most cases, cfparse parser is more useful than a string parser. It could be used almost everywhere, just one edge-case is when the step definition contains "{....}" pair. In this case user still could select string parser

@codecov
Copy link

codecov bot commented Jan 3, 2022

Codecov Report

Merging #472 (7aa9698) into master (f4ed62d) will increase coverage by 0.38%.
The diff coverage is 97.56%.

❗ Current head 7aa9698 differs from pull request most recent head c4b8da7. Consider uploading reports for the commit c4b8da7 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #472      +/-   ##
==========================================
+ Coverage   95.91%   96.30%   +0.38%     
==========================================
  Files          49       49              
  Lines        1640     1839     +199     
  Branches      179      195      +16     
==========================================
+ Hits         1573     1771     +198     
- Misses         41       43       +2     
+ Partials       26       25       -1     
Impacted Files Coverage Δ
tests/feature/test_cucumber_json.py 100.00% <ø> (ø)
pytest_bdd/utils.py 92.10% <90.00%> (-0.76%) ⬇️
pytest_bdd/parsers.py 87.17% <91.66%> (-8.48%) ⬇️
pytest_bdd/parser.py 99.34% <98.51%> (-0.20%) ⬇️
pytest_bdd/scenario.py 91.41% <100.00%> (-0.26%) ⬇️
tests/args/cfparse/test_args.py 100.00% <100.00%> (ø)
tests/args/parse/test_args.py 100.00% <100.00%> (ø)
tests/args/regex/test_args.py 100.00% <100.00%> (ø)
tests/feature/test_outline.py 100.00% <100.00%> (ø)
tests/feature/test_report.py 100.00% <100.00%> (+24.32%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f4ed62d...c4b8da7. Read the comment docs.

@elchupanebrej
Copy link
Author

elchupanebrej commented Jan 3, 2022

Have to be merged after #469 because it brokes obsolete test case

@elchupanebrej elchupanebrej force-pushed the default_parser_switched_to_cfparse branch 2 times, most recently from 8ce5dbb to 749190c Compare January 6, 2022 13:51
@elchupanebrej elchupanebrej force-pushed the default_parser_switched_to_cfparse branch from 749190c to 52b58f8 Compare January 14, 2022 17:03
@elchupanebrej elchupanebrej marked this pull request as draft January 14, 2022 17:04
@elchupanebrej elchupanebrej force-pushed the default_parser_switched_to_cfparse branch from 7aa9698 to c4b8da7 Compare January 14, 2022 17:46
@elchupanebrej elchupanebrej deleted the default_parser_switched_to_cfparse branch January 14, 2022 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant