-
Notifications
You must be signed in to change notification settings - Fork 348
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: upgrade pytest-cov #651
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This causes coverage dropping on codecov at least.
This might speed up tests a bit.
Override testdir.
The config appears to be missing in subprocesses?! (https://travis-ci.org/pytest-dev/pytest-django/builds/429186955#L750) cwd is now '/tmp/pytest-of-travis/pytest-0/test_django_db_reset_sequences_fixture0' 1963.5ece: New process: executable: /home/travis/build/pytest-dev/pytest-django/.tox/py36-dj20-postgres/bin/python 1963.5ece: New process: cmd: /home/travis/build/pytest-dev/pytest-django/.tox/py36-dj20-postgres/lib/python3.6/site-packages/pytest.py --basetemp=/tmp/pytest-of-travis/pytest-0/test_django_db_reset_sequences_fixture0/runpytest-0 -v --reuse-db 1963.5ece: New process: parent pid: 1951 1963.5ece: -- config ---------------------------------------------------- 1963.5ece: _include: None 1963.5ece: _omit: None 1963.5ece: attempted_config_files: .coveragerc 1963.5ece: setup.cfg 1963.5ece: tox.ini 1963.5ece: branch: False 1963.5ece: concurrency: None 1963.5ece: config_files: tox.ini 1963.5ece: cover_pylib: False 1963.5ece: data_file: /tmp/pytest-of-travis/pytest-0/test_django_db_reset_sequences_fixture0/.coverage But not for the python process before that (also in this tmpdir already)!
=> #656 |
Closing in favor of #657. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This causes coverage dropping on codecov at least.
Findings:
--cov
(2nd commit) is very slow (10min / job), but restores more coverage already, unlike--cov=$PWD
?!