Avoid unnecessary rinfo calls after creating gateways #909
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hopefully this fixes pytest-dev#907, as seems this is the only change in pytest-dev#901 which is somehow related.
|
I'll try to run sqlalchemy test on this branch later |
|
@CaselIT oh that would be great, thanks! |
CaselIT
added a commit
to sqlalchemy/sqlalchemy
that referenced
this pull request
May 18, 2023
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
|
This run should use the patch you added https://github.com/sqlalchemy/sqlalchemy/actions/runs/5018530060 It will take a while since there are other 3 pipeline in the queue before it |
CaselIT
added a commit
to sqlalchemy/sqlalchemy
that referenced
this pull request
May 18, 2023
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
CaselIT
added a commit
to sqlalchemy/sqlalchemy
that referenced
this pull request
May 18, 2023
Change-Id: I4bc459895692931db30b9e5b98d10d94f1cdc5ac
|
Edited the link above since fumbled the tox config |
|
Thanks @CaselIT. It passed! Can you trigger a new run to make sure it was not a fluke? |
Done https://github.com/sqlalchemy/sqlalchemy/actions/runs/5018530060 |
RonnyPfannschmidt
approved these changes
May 19, 2023
Co-authored-by: Ronny Pfannschmidt <[email protected]>
|
Re-run also passed. trying a 3rd time just to be sure (3.3.0 failed each time in 4 runs it did, so we should be good) |
|
also 3rd re-run seems fine |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully this fixes #907, as seems this is the only change in #901 which is somehow related.