Remove py dependency #137
Merged
Remove py dependency #137
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `py.std` module is just an alias for the built in Python modules, so doesn't serve any purpose over importing them directly. `TerminalWriter` can instead be imported from Pytest directly via a private import, which means the `py` dependency can be removed.
|
With apologies for the gratuitous tag: @northernSage, it'd be great to have this merged into a new release! |
northernSage
approved these changes
Sep 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
py.stdmodule is just an alias for the built in Python modules, so doesn't serve any purpose over importing them directly.TerminalWritercan instead be imported from Pytest directly via a private import, which means thepydependency can be removed.This follows the suggestions from #110.
My motivation for doing this is that we hit
DeprecationWarningsfrompywhen using pytest-xprocess because we elevate warnings to errors when we run tests.Checklist:
CHANGELOG.rst, summarizing the change and linking to the issue.pre-commithooks and fix any issues.pytestand make sure no tests failed.