Skip to content

Commit

Permalink
add issue references to the todos
Browse files Browse the repository at this point in the history
  • Loading branch information
RonnyPfannschmidt committed Dec 20, 2018
1 parent d0afc85 commit 8903cdb
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 0 deletions.
2 changes: 2 additions & 0 deletions src/_pytest/config/__init__.py
Original file line number Diff line number Diff line change
Expand Up @@ -270,6 +270,7 @@ def parse_hookimpl_opts(self, plugin, name):
opts = {}
if opts is not None:
# TODO: DeprecationWarning, people should use hookimpl
# https://github.com/pytest-dev/pytest/issues/4562
known_marks = {m.name for m in getattr(method, "pytestmark", [])}

for name in ("tryfirst", "trylast", "optionalhook", "hookwrapper"):
Expand All @@ -286,6 +287,7 @@ def parse_hookspec_opts(self, module_or_class, name):

if name.startswith("pytest_"):
# todo: deprecate hookspec hacks
# https://github.com/pytest-dev/pytest/issues/4562
known_marks = {m.name for m in getattr(method, "pytestmark", [])}
opts = {
"firstresult": hasattr(method, "firstresult")
Expand Down
2 changes: 2 additions & 0 deletions src/_pytest/python.py
Original file line number Diff line number Diff line change
Expand Up @@ -1290,6 +1290,8 @@ def __init__(
self.keywords.update(keywords)

# todo: this is a hell of a hack
# https://github.com/pytest-dev/pytest/issues/4569

self.keywords.update(
dict.fromkeys(
[
Expand Down

0 comments on commit 8903cdb

Please sign in to comment.