Skip to content

Commit

Permalink
Rename FixtureDef.finalizer to FixtureDef.finalizers
Browse files Browse the repository at this point in the history
  • Loading branch information
nicoddemus committed Nov 12, 2017
1 parent 6d3fe0b commit a6f2d2d
Showing 1 changed file with 8 additions and 10 deletions.
18 changes: 8 additions & 10 deletions _pytest/fixtures.py
Original file line number Diff line number Diff line change
@@ -1,14 +1,15 @@
from __future__ import absolute_import, division, print_function

import functools
import inspect
import sys
import warnings
from collections import OrderedDict

import functools
import attr
import py
from py._code.code import FormattedExcinfo

import attr
import _pytest
from _pytest import nodes
from _pytest._code.code import TerminalRepr
Expand All @@ -23,9 +24,6 @@
from _pytest.outcomes import fail, TEST_OUTCOME


from collections import OrderedDict


def pytest_sessionstart(session):
import _pytest.python

Expand Down Expand Up @@ -737,17 +735,17 @@ def __init__(self, fixturemanager, baseid, argname, func, scope, params,
self.argnames = getfuncargnames(func, is_method=unittest)
self.unittest = unittest
self.ids = ids
self._finalizer = []
self._finalizers = []

def addfinalizer(self, finalizer):
self._finalizer.append(finalizer)
self._finalizers.append(finalizer)

def finish(self, request):
exceptions = []
try:
while self._finalizer:
while self._finalizers:
try:
func = self._finalizer.pop()
func = self._finalizers.pop()
func()
except: # noqa
exceptions.append(sys.exc_info())
Expand All @@ -765,7 +763,7 @@ def finish(self, request):
# keep instances alive
if hasattr(self, "cached_result"):
del self.cached_result
self._finalizer = []
self._finalizers = []

def execute(self, request):
# get required arguments and register our own finish()
Expand Down

0 comments on commit a6f2d2d

Please sign in to comment.