Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(internal) should we clean up the python 2 only issues now that core support has ended? #7296

Closed
asottile opened this issue Jun 2, 2020 · 7 comments
Labels
type: infrastructure improvement to development/releases/CI structure

Comments

@asottile
Copy link
Member

asottile commented Jun 2, 2020

this would cut down a bit on our backlog and would give us more room to focus on open issues.

I'm proposing the following:

  • close those tagged with [platform: python 2 only]
  • leave a comment to the effect of "core support has ended for python 2, however community patches are still accepted for this issue (even though this issue is closed) <<link to the 2.7 / 3.4 support document>>

@nicoddemus @bluetech @RonnyPfannschmidt thoughts?

@asottile asottile added the type: infrastructure improvement to development/releases/CI structure label Jun 2, 2020
@RonnyPfannschmidt
Copy link
Member

I enthusiastically approve

@bluetech
Copy link
Member

bluetech commented Jun 2, 2020

Looking at the list of issues https://github.com/pytest-dev/pytest/issues?q=is%3Aopen+is%3Aissue+label%3A%22platform%3A+python+2+only%22

Looks fine to me to close them.

@symonk
Copy link
Member

symonk commented Jun 2, 2020

+1, sounds good!

@nicoddemus
Copy link
Member

Sure! 👍

@asottile
Copy link
Member Author

asottile commented Jun 2, 2020

alright, I'll handle this then!

@nicoddemus
Copy link
Member

Cool thanks @asottile!

@asottile
Copy link
Member Author

asottile commented Jun 2, 2020

this has been done -- this is the messaging I used:

hello, first off thank you for the issue!

python 2.x support has ended for pytest core.

we've decided in #7296 to close the python-2-specific issues to free up some space in our backlog. however, in accordance to our python 2.7 and 3.4 support community patches will still be accepted to the 4.6 series to fix bugs for python 2. (so if this issue is important to you and you have a patch to fix it, feel free to make a PR targeting the 4.6.x branch despite this ticket being closed).

@asottile asottile closed this as completed Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: infrastructure improvement to development/releases/CI structure
Projects
None yet
Development

No branches or pull requests

5 participants