Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix a few broken links in the documentation. #10339

Merged
merged 1 commit into from
Oct 6, 2022
Merged

Fix a few broken links in the documentation. #10339

merged 1 commit into from
Oct 6, 2022

Conversation

Moisan
Copy link
Contributor

@Moisan Moisan commented Oct 5, 2022

I fixed a few broken links in the documentation as well as in a docstring.

  • Include documentation when adding new features.
  • Include new tests or update existing tests when applicable.
  • Allow maintainers to push and squash when merging my commits. Please uncheck this if you prefer to squash the commits yourself.

RonnyPfannschmidt
RonnyPfannschmidt approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@RonnyPfannschmidt RonnyPfannschmidt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good, I presume you checked the user names/renames

@Moisan
Copy link
Contributor Author

Moisan commented Oct 5, 2022

I presume you checked the user names/renames

Yes I did.

@RonnyPfannschmidt
Copy link
Member

Unfortunately I won't be able verify the failures until tommorow, but it seems coverage related

@nicoddemus
Copy link
Member

re-running the failed jobs due to coverage.

Thanks @Moisan!

@nicoddemus nicoddemus enabled auto-merge October 6, 2022 15:58
@nicoddemus nicoddemus added the needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch label Oct 6, 2022
@nicoddemus nicoddemus merged commit 4677580 into pytest-dev:main Oct 6, 2022
@nicoddemus nicoddemus added backport 7.1.x and removed needs backport applied to PRs, indicates that it should be ported to the current bug-fix branch labels Oct 6, 2022
@github-actions github-actions bot mentioned this pull request Oct 6, 2022
Merged
@Moisan Moisan deleted the doc_broken_links branch October 6, 2022 19:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonnyPfannschmidt RonnyPfannschmidt RonnyPfannschmidt approved these changes

@nicoddemus nicoddemus nicoddemus approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Moisan @RonnyPfannschmidt @nicoddemus