Parse args from file

[levsa]

Fixes #11871 using the proposed solution in #11871 (comment)

Adds support for reading file_or_dir positional arguments from a file
using the prefix character '@', like e.g.:

pytest @tests.txt

Added tests, but not sure how/where to add documentation, I'm guessing it should be in the output of pytest --help?

[levsa]

I don't understand why the test fails on py310 and py311. It seems to do it only when running with tox, it passes when running with virtual env manually (based on 3.10.2). Some issue with default encoding for open() missing in argparse.py, probably because tox.ini has PYTHONWARNDEFAULTENCODING=1?

[bluetech]

It's a Python bug python/cpython#85308 that it seems was only fixed in Python 3.12. So we should ignore EncodingWarnings for this test, see here how to do it: https://docs.pytest.org/en/stable/how-to/capture-warnings.html#pytest-mark-filterwarnings

[bluetech]

Thanks!

Can you also add a test using pytester to testing/acceptance_test.py? This will make sure it works end-to-end.

[levsa]

Thanks!

Can you also add a test using pytester to testing/acceptance_test.py? This will make sure it works end-to-end.

Sure!

[bluetech]

There is no reason to warn about it, I think it's a good thing.

…

On Thu, Mar 7, 2024, at 21:38, Levon Saldamli wrote: ***@***.**** commented on this pull request. In changelog/11871.feature.rst <#12085 (comment)>: > +Added support for reading ``file_or_dir`` positional arguments from a file +using the prefix character '@', like e.g.: + +``pytest @tests.txt`` You're right, it is not only positional arguments. `-k foo` in the file is treated as a `-k`-argument. Is this ok, as long as I update the changelog and warn about it? Not sure if and how it would be possible to avoid it. — Reply to this email directly, view it on GitHub <#12085 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AAJKW7UTZYQFEYDN7KBVEC3YXC635AVCNFSM6AAAAABEJ6MDI6VHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTSMRTGM3TAOJRGE>. You are receiving this because you commented.Message ID: ***@***.***>

[levsa]

Thanks!
Can you also add a test using pytester to testing/acceptance_test.py? This will make sure it works end-to-end.

Sure!

Acceptance test added.

[bluetech]

A few small comments, but with them I think this is good to go.

[levsa]

A few small comments, but with them I think this is good to go.

Thanks! Updated now.

[nicoddemus]

Great work, thanks!

We should add this feature to the docs, I think here is a good place to mention it:

https://docs.pytest.org/en/stable/how-to/usage.html#specifying-which-tests-to-run

[levsa]

Great work, thanks!

We should add this feature to the docs, I think here is a good place to mention it:

https://docs.pytest.org/en/stable/how-to/usage.html#specifying-which-tests-to-run

I made an attempt, please check if it works :)

[nicoddemus]

LGTM!

[patrickvonplaten]

That's a very nice feature - can it also read in parameterized tests though such as:
pytest tests/tasks_test.py::test_task_scoring[param_1]

from a file?

It doesn't seem to find them

[The-Compiler]

@patrickvonplaten The tests added in this PR test exactly that. I suggest you open a new issue with more information and a reproducer.

[patrickvonplaten]

Actually everything works just fine - sorry for the noise