Add -rp and -rP options to report passing tests. #1232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
-rP is an alternative to `-s` for viewing the output of passing tests. This causes the captured stdout/stderr of passing tests to be output in the same way as that of failing tests. -rp adds a simple one-line-per-test summary for passing tests. Neither option is included by -ra. Additional changes to `pytest_capturelog` and `pytest_catchlog` are needed for this option to also output captured logs: They must be changed to use `rep.sections.add` instead of `rep.longrepr.addsection`, and to add these additional sections even if the test passes, since passing tests don't seem to have a `longrepr` at report time.
|
It looks like no changes are needed to |
|
Could you please add yourself to |
|
Sure thing. |
|
I just noticed there are no tests for this feature... we should have at least two tests, one for |
|
just wanted to chime in and say "yeah". Just needed "-rp" the other day. looking forward to the merge :) |
|
Added two tests for |
|
The |
RonnyPfannschmidt
added a commit
that referenced
this pull request
Dec 9, 2015
Add -rp and -rP options to report passing tests.
|
Well done, thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
-rPis an alternative to-sfor viewing the output of passing tests.This causes the captured stdout/stderr of passing tests to be output in
the same way as that of failing tests.
-rpadds a simple one-line-per-test summary for passing tests.Neither option is included by
-ra.Additional changes topytest_capturelogandpytest_catchlogareneeded for this option to also output captured logs: They must be
changed to use
rep.sections.addinstead ofrep.longrepr.addsection,and to add these additional sections even if the test passes, since
passing tests don't seem to have a
longreprat report time.