-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: simplify bound method representation #12492
Merged
RonnyPfannschmidt
merged 16 commits into
pytest-dev:main
from
farbodahm:refactor/simplify-bound-method-representation
Jun 21, 2024
Merged
refactor: simplify bound method representation #12492
RonnyPfannschmidt
merged 16 commits into
pytest-dev:main
from
farbodahm:refactor/simplify-bound-method-representation
Jun 21, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
psf-chronographer
bot
added
the
bot:chronographer:provided
(automation) changelog entry is part of PR
label
Jun 20, 2024
farbodahm
force-pushed
the
refactor/simplify-bound-method-representation
branch
3 times, most recently
from
June 20, 2024 12:21
685e457
to
7828d15
Compare
farbodahm
force-pushed
the
refactor/simplify-bound-method-representation
branch
2 times, most recently
from
June 21, 2024 14:18
0b912ca
to
f115a0f
Compare
Co-Authored-By: Sviatoslav Sydorenko <[email protected]>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
farbodahm
force-pushed
the
refactor/simplify-bound-method-representation
branch
from
June 21, 2024 15:55
de3a747
to
f6fef46
Compare
RonnyPfannschmidt
approved these changes
Jun 21, 2024
Glyphack
pushed a commit
to Glyphack/pytest
that referenced
this pull request
Jul 30, 2024
Co-authored-by: Sviatoslav Sydorenko <[email protected]> Co-authored-by: Farbod Ahmadian <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #389
With the help of @flub and @obestwalter, we were able to find an easy way to simplify the output of assertion failures to something like this, while keeping the old behavior same as before for unbounded objects:
However, I opened an issue (#12499) to refactor the data structure of assertions AST (in
rewerite.py
) from string to something more flexible.