Docs: Fix custom styling, restore bullets

[ferdnyc]

• Move the custom CSS to a dedicated pytest.css file in _static/, and reference it from the configuraton's html_css_files list.
• Update the list-customization styling to only affect .sidebar-scroll (the navigation sidebar), so that bullets are visible in the rest of the documentation.
• Remove the list indent from the navigation sidebar, but only at the top level, so that navigation is still nested with visible indents.

Fixes #12573
Fixes #12576
Closes #12575
Updates #12290
Updates #12326

Before

After

[ferdnyc]

A slight change from @pradyunsg's #12575, as I discovered that the navigation sidebar isn't styled .sidebar (surprisingly), but the events sidebar is. So, nesting these changes under .sidebar would've hit the wrong part of the docs.

The navigation content-list is under a div at .sidebar-drawer > .sidebar-container > .sidebar-scroll.

I suppose I could've used either of those parent selectors instead, except for the .sidebar-scroll > ul change.

[pradyunsg]

Wait, this was not meant for TOC sidebar at all. It's meant for the literal "sidebar" thing in reStructuredText: https://pradyunsg.me/furo/kitchen-sink/generic/#sidebar

[pradyunsg]

My understanding is that folks didn't like the extra indentation that having list within sidebar, specifically due to lack of width for content in an already thin sidebar.

[ferdnyc]

Oh, no, pytest devs want list markers in the event sidebar. The original CSS this replaces was intended to remove them only from the TOC/navigation sidebar, but it was overzealous by a lot.

[pradyunsg]

Oh, fun.

[ferdnyc]

I added an additional commit with a small style fix, as IMHO this looks extremely unfortunate:

With the added margin it becomes this, which is perfect:

[nicoddemus]

Thanks a lot @ferdnyc, we greatly appreciate you following up here. ❤️

I have skimmed through the docs and everything looks great to me. 👍

[pradyunsg]

Suggested change

	.sidebar-scroll ul {list-style: none;}
	.sidebar-scroll > ul {padding-left: 0;}
	.sidebar-scroll li {margin: 0.4em 0;}
	.sidebar ul {
	list-style: none;
	padding-left: 0;
	}
	.sidebar ul li {
	margin: 0.4em 0;
	}

[pradyunsg]

I'm gonna say this isn't necessary because I clearly misunderstood what the goals were here.

[pradyunsg]

I'm only now noticing the completely custom sidebar in pytest's documentation. I'll file a separate issue/PR about that, I guess.

[pradyunsg]

I've filed #12584 for that.

[pradyunsg]

FWIW, I don't consider my PR to be "competing" with this one and have no concerns with this landing -- I'm happy to rebase mine once this one goes through. I realise that might not have been clear with my previous two comments. 😅

[nicoddemus]

Sorry I'm not keen on all the details so I must ask: @pradyunsg in your opinion is this PR ready to merge?

[nicoddemus]

@ferdnyc @pradyunsg gentle ping

[ferdnyc]

@nicoddemus @pradyunsg

To be honest, I thought this was already handled with the other PRs that have already been merged. I'll take a look at the current state of the docs and see if anything here is still needed.

[ferdnyc]

Hmm. Looking at https://docs.pytest.org/en/latest/, list bullets are already back in the main content. They're not shown in the trainings & events sidebar, but the excessive indentation that was being caused when they were hidden is also gone, and I'm not sure my changes here would affect that anyway.

And the main/navigation sidebar is completely changed from the previous configs, so my changes there no longer have any purpose.

As for the behind-the-scenes changes, the CSS is already moved from _templates/style.html to _static/pytest-custom.css.

I'm not sure there's anything left to do in this PR. All of the linked issues/PRs are already closed/merged. I think it's best to just close this one; everything it was trying to do is handled already.

[nicoddemus]

Thanks @ferdnyc!