drop python 3.0-3.2 support code from setup.py #1678
Conversation
| @@ -27,10 +27,12 @@ | |||
|
|
|||
| Thanks to `@RedBeardCode`_ for the PR(`#1664`_) | |||
|
|
|||
| * removed support code for python 3 < 3.3 addresssing (`#1627`_) | |||
|
LGTM, feel free to merge after fixing the small typo. 😁 |
| extras_require[':sys_platform=="win32"'] = ['colorama'] | ||
| else: | ||
| if sys.version_info < (2, 7) or (3,) <= sys.version_info < (3, 2): | ||
| if sys.version_info < (2, 7): |
There was a problem hiding this comment.
This might be as well sys.version_info[:2] == (2, 6), for consistency with the marker usage in 54
|
There is more stuff which should be changed/dropped to properly remove support |
RonnyPfannschmidt
force-pushed
the
drop-python30-32
branch
from
0e20c14 to
e877e25
Compare
|
@The-Compiler in this pr i just want to kill the documented/normal install one i plan to add some more PR's to remove strange code for example i stumbled on a python 2.4 support thing ^^ |
|
|
Okay, but at least adjust the documentation then. |
|
im on it |
|
Oh sorry, I didn't have the code with me to check the docs... agree that we should properly drop the support in a single PR (setup.py, docs, code, etc) |
|
should i drop anything else? (atm i really only want to drop docs and mentions, then phase bits of support code out in the |
|
I'm with @nicoddemus - not sure what the rationale for only dropping half of it is? If we drop the code in this PR as well, we can be sure it's actually gone and we don't forget about it 😉 |
|
ok |
|
after investigating the support code for getstatementrange, it addresses python 2.4 and should be removed in a different pr as for the assertion rewriter, - the exact code are conditionals also valid for python 2.6, and i would like to leave them until python 2.6 removal |
Oh, right, didn't think of that. Could you still adjust the xfail in @pytest.mark.xfail("sys.version_info[:3] < (2,7,0) or "
"((3,0) <= sys.version_info[:2] < (3,2))")
def test_source_of_class_at_eof_without_newline(tmpdir): |
|
i think i would like to remove that as we remove python2.6 as well, since we right now still have a testsuite that can run on 3.2, does any enterprise distro keep users on that? |
|
Huh - what's the point of having a testsuite passing on 3.2 when we say we drop 3.2 support? 😉 As for conservative distros, I'm pretty sure they'll either stick with Python 2 altogether, or not going to use pytest 3.0. Hell, pip dropped it 😉 |
|
true, will change the condition :) |
|
I'd like to see appveyor pass here, but it doesn't, see #1690. @nicoddemus to the rescue? Or anyone else on Windows? 😆 edit: heh, back to normal right now 😆 |
|
😬 |
|
Thanks! ✨ |
This contribution drop the execution of the unit tests on Python 3.2. Python 3.2 is not supported by pytest anymore [1] and there are no more security updates [2]. confiture should not encourage the use of an abandoned version of Python. Also, this contribution adds the current Python 3 version (3.6) to the list of the tested environments. [1] pytest-dev/pytest#1678 [2] https://www.python.org/dev/peps/pep-0392/#lifespan
addresses #1627