-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AttributeError chaining bug #1944 fix #1945
Conversation
Thanks, I've seen this happen on occasion but never took the time to properly look it up. Would you mind add a CHANGELOG entry as well? |
@nicoddemus done |
Thanks! Maybe it'd make sense to include a test which creates a file like the one in the issue, runs pytest over it, and checks that "AttributeError" isn't in the output? Should be really straightforward to add and prevent regressions for this in the future. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you guys for fixing this issue :)
Added a test, rebased against master. |
Can you please take a look at the failing builds? |
All passed now. |
Thanks! |
Thanks for submitting a PR, your contribution is really appreciated!
Here's a quick checklist that should be present in PRs:
master
; for new features, targetfeatures
;AUTHORS
;CHANGELOG.rst
CHANGELOG
, so please add a thank note to yourself ("Thanks @user for the PR") and a link to your GitHub profile. It may sound weird thanking yourself, but otherwise a maintainer would have to do it manually before or after merging instead of just using GitHub's merge button. This makes it easier on the maintainers to merge PRs.