Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce a task to generate the announcement file for releases #2397

Merged
merged 1 commit into from
May 11, 2017

Conversation

nicoddemus
Copy link
Member

@nicoddemus nicoddemus commented May 10, 2017

As discussed in the mailing list, introducing invoke tasks to simplify development and release process.

I started with a task to generate the AUTHORS file from git history but because pytest has a very old history, a lot of the names (60+) are not in a proper "name" format, a few examples:

famousgarkin
fijal
foxx
gabriel.reis
getxsick

I realized that finding the proper names would be a ton of work and not really worth the trouble, given that the AUTHORS file is updated during PRs and not during the release process.

This is the perfect place to introduce a task to update the CHANGELOG (#2390) IMO. 😁

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 92.345% when pulling 66ba3c3 on nicoddemus:announce-task into daca618 on pytest-dev:features.

@RonnyPfannschmidt
Copy link
Member

@nicoddemus can we introduce a git authormap that people may update at their leisure?

@nicoddemus
Copy link
Member Author

can we introduce a git authormap that people may update at their leisure?

It is a possibility, but unfortunately I suspect a lot of people won't even be aware that their name now is incorrect in the AUTHORS file. Also I'm not sure this will gain us much because AUTHORS is updated during PRs, not during the release process, and PR contributors will also have to add a CHANGELOG entry anyway (even after introducing towncrier).

I thought about implementing a task that would only add new authors after a certain commit, so authors up until now would be preserved; but decided not to bother for the reasons stated above.

Regardless this topic is parallel to the task being introduced by this PR, which I find useful.

@RonnyPfannschmidt RonnyPfannschmidt merged commit b6125d9 into pytest-dev:features May 11, 2017
@nicoddemus nicoddemus deleted the announce-task branch May 11, 2017 13:12
@nicoddemus
Copy link
Member Author

Thanks @RonnyPfannschmidt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants