Handle exceptions in subrequest finalizers

[rmfitzpatrick]

Should resolve #2440 by following a similar procedure as SetupState._callfinalizers().

• Add a new news fragment into the changelog folder
  • name it $issue_id.$type for example (588.bug)
  • if you don't have an issue_id change it to the pr id after creating the pr
  • ensure type is one of removal, feature, bugfix, vendor, doc or trivial
  • Make sure to use full sentences with correct case and punctuation, for example: "Fix issue with non-ascii contents in doctest text files."
• Target: for bugfix, vendor, doc or trivial fixes, target master; for removals or features target features;
• Make sure to include reasonable tests for your change if necessary

[coveralls]

Coverage increased (+0.005%) to 92.133% when pulling 5a856b6 on rmfitzpatrick:pytest2440_handle_subrequest_finalizer_exceptions into f0541b6 on pytest-dev:master.

[coveralls]

Coverage increased (+0.005%) to 92.133% when pulling 5a856b6 on rmfitzpatrick:pytest2440_handle_subrequest_finalizer_exceptions into f0541b6 on pytest-dev:master.

[nicoddemus]

Awesome @rmfitzpatrick, thanks.

I've updated the test to ensure the exception is being re-raised. I will merge as soon as CI passes again. 👍

[coveralls]

Coverage increased (+0.005%) to 92.133% when pulling dd316eb on rmfitzpatrick:pytest2440_handle_subrequest_finalizer_exceptions into f0541b6 on pytest-dev:master.

[coveralls]

Coverage increased (+0.007%) to 92.134% when pulling 4e4ebbe on rmfitzpatrick:pytest2440_handle_subrequest_finalizer_exceptions into 0908f40 on pytest-dev:master.