Fix progress report when tests fail during teardown #3110
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RonnyPfannschmidt
approved these changes
Jan 12, 2018
_pytest/terminal.py
Outdated
| self._show_progress_info = (self.config.getoption('capture') != 'no' and | ||
| self.config.getini('console_output_style') == 'progress') | ||
| self._progress_nodeids_reported = set() | ||
| self._show_progress_info = (self.config.getoption('capture') != 'no' and not self.config.getoption('setupshow') |
There was a problem hiding this comment.
that condition is starting to look complex enough for putting it in a small function
There was a problem hiding this comment.
Good idea, thanks. Done.
|
fabulous, thanks 👍 |
blueyed
added a commit
to blueyed/pytest
that referenced
this pull request
Feb 10, 2020
What's needed to fix pytest-dev#3088 seems to be checking for `rep.when == "setup"`. This then needs adjustments though (to code done in pytest-dev#3110) to make this work with xdist. It appears to make sense to split it into hooks that are run per test (for eventually writing if past edge), and one that gets run at the end really (not requiring to check for "last item" then).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #3088