Add documentation blurb for --strict #3558
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Feels out of place in there, plus the reference documentation already contains the reference API to all mark-related classes
asottile
approved these changes
Jun 9, 2018
doc/en/mark.rst
Outdated
| Raising errors on unknown marks: --strict | ||
| ----------------------------------------- | ||
|
|
||
| The ``--strict`` command-line flag can be used to raise errors when marks not registered in the ``pytest.ini`` file. |
There was a problem hiding this comment.
how about
When the ``--strict`` command-line flag is passed, any marks not registered in the ``pytest.ini`` file will trigger an error.or I guess, a one-word fix to the current phrasing would be to s/when marks not/when marks are not/
There was a problem hiding this comment.
I like yours better, thanks!
doc/en/mark.rst
Outdated
| slow | ||
| serial | ||
|
|
||
| This can be used to prevent users mistyping mark names by accident. Test suites that want to enforce that this |
asottile
approved these changes
Jun 9, 2018
blueyed
approved these changes
Jun 9, 2018
There was a problem hiding this comment.
LGTM, thanks!
As for pytest-django we are registering them like this: https://github.com/pytest-dev/pytest-django/blob/b93e0c556fe6c357dfc39363ed9cbe6b7e1e64c6/pytest_django/plugin.py#L187-L190
|
Great, thanks! @blueyed next time feel free to merge it yourself. 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also remove Mark api from mark.rst: Feels out of place in there, plus the reference documentation already contains the reference API to all mark-related classes.
Fix #3549