Fix CallInfo.__repr__ for unfinished call #4381
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blueyed
force-pushed
the
callinfo-repr
branch
from
8da6ecf to
a8b011d
Compare
blueyed
force-pushed
the
callinfo-repr
branch
from
a8b011d to
27dab4e
Compare
blueyed
commented
Nov 13, 2018
| @@ -224,7 +224,8 @@ def __repr__(self): | |||
| if self.excinfo: | |||
| status = "exception: %s" % str(self.excinfo.value) | |||
| else: | |||
| status = "result: %r" % (self.result,) | |||
| result = getattr(self, "result", "<NOTSET>") | |||
| status = "result: %r" % (result,) | |||
There was a problem hiding this comment.
@RonnyPfannschmidt
I think compat.NOTSET is not needed here?!
(as outlined in #3560 (comment))
Codecov Report
@@ Coverage Diff @@
## master #4381 +/- ##
=========================================
+ Coverage 95.88% 95.9% +0.02%
=========================================
Files 111 111
Lines 24928 24938 +10
Branches 2431 2431
=========================================
+ Hits 23901 23916 +15
+ Misses 726 724 -2
+ Partials 301 298 -3
Continue to review full report at Codecov.
|
|
#4299 makes this obsolete |
|
#4299 is for features, this is for master. (the issue is really annoying when you run into it, and should be fixed already) |
nicoddemus
approved these changes
Nov 13, 2018
This was referenced Nov 14, 2018
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3554
Ref: #3560
Ref: #3562