Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation configuration files #4609

Merged

Conversation

yoavcaspi
Copy link
Contributor

Fix #3375

@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #4609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4609   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         111      111           
  Lines       24678    24678           
  Branches     2446     2446           
=======================================
  Hits        23630    23630           
  Misses        740      740           
  Partials      308      308
Flag Coverage Δ
#docs 29.57% <ø> (+0.07%) ⬆️
#doctesting 29.57% <ø> (+0.07%) ⬆️
#linting 29.57% <ø> (+0.07%) ⬆️
#linux 95.58% <ø> (ø) ⬆️
#nobyte 92.38% <ø> (ø) ⬆️
#numpy 93.19% <ø> (ø) ⬆️
#pexpect 42.13% <ø> (ø) ⬆️
#py27 93.78% <ø> (-0.01%) ⬇️
#py34 91.86% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.9% <ø> (+0.06%) ⬆️
#py37 93.93% <ø> (+0.03%) ⬆️
#trial 93.19% <ø> (ø) ⬆️
#windows 93.92% <ø> (ø) ⬆️
#xdist 93.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c426b...149620f. Read the comment docs.

1 similar comment
@codecov
Copy link

codecov bot commented Jan 6, 2019

Codecov Report

Merging #4609 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #4609   +/-   ##
=======================================
  Coverage   95.75%   95.75%           
=======================================
  Files         111      111           
  Lines       24678    24678           
  Branches     2446     2446           
=======================================
  Hits        23630    23630           
  Misses        740      740           
  Partials      308      308
Flag Coverage Δ
#docs 29.57% <ø> (+0.07%) ⬆️
#doctesting 29.57% <ø> (+0.07%) ⬆️
#linting 29.57% <ø> (+0.07%) ⬆️
#linux 95.58% <ø> (ø) ⬆️
#nobyte 92.38% <ø> (ø) ⬆️
#numpy 93.19% <ø> (ø) ⬆️
#pexpect 42.13% <ø> (ø) ⬆️
#py27 93.78% <ø> (-0.01%) ⬇️
#py34 91.86% <ø> (+0.06%) ⬆️
#py35 91.88% <ø> (+0.06%) ⬆️
#py36 91.9% <ø> (+0.06%) ⬆️
#py37 93.93% <ø> (+0.03%) ⬆️
#trial 93.19% <ø> (ø) ⬆️
#windows 93.92% <ø> (ø) ⬆️
#xdist 93.79% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a4c426b...149620f. Read the comment docs.

@@ -889,6 +889,9 @@ Here is a list of builtin configuration options that may be written in a ``pytes
file, usually located at the root of your repository. All options must be under a ``[pytest]`` section
(``[tool:pytest]`` for ``setup.cfg`` files).

.. warning:: usage of configuration file different than the canonical, i.e. ``pytest.ini``
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this warning should be specifically for setup.cfg tox and pytest use the same ini parser

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see, I'm new to Github, can you suggest me how to do it?

  • create a new PR?
  • add new commit?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Adding a new commit or amending and force pushing are all valid. 👍

@@ -889,6 +889,9 @@ Here is a list of builtin configuration options that may be written in a ``pytes
file, usually located at the root of your repository. All options must be under a ``[pytest]`` section
(``[tool:pytest]`` for ``setup.cfg`` files).

.. warning:: usage of configuration file different than the canonical, i.e. ``pytest.ini``
can break other tools configurations.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My suggestion:

.. warning:: 
	Usage of ``setup.cfg`` is not recommended unless for very simple use cases: ``.cfg``
    files use a different parser than ``pytest.ini`` and ``tox.ini`` which might cause hard to track
    down problems. 
    When possible, it is recommended to use the latter files to hold your pytest configuration.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I like this suggestion :-)

@nicoddemus
Copy link
Member

Thanks!

@nicoddemus
Copy link
Member

Ignoring AppVeyor because codecov is acting up again

@nicoddemus nicoddemus merged commit a0ab5a7 into pytest-dev:master Jan 10, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants