Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP collectfile: improve assertion [ci skip] #4790

Closed
wants to merge 1 commit into from

Conversation

blueyed
Copy link
Contributor

@blueyed blueyed commented Feb 13, 2019

@blueyed blueyed changed the title collectfile: improve assertion collectfile: improve assertion [ci skip] Feb 13, 2019
Copy link
Member

@nicoddemus nicoddemus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

Meant for testing.. let's wait for feedback from #4788 (comment).

@nicoddemus nicoddemus changed the title collectfile: improve assertion [ci skip] WIP collectfile: improve assertion [ci skip] Feb 13, 2019
@rouault
Copy link

rouault commented Feb 13, 2019

OK, more interesting info from the assert branch:

c:\python27\lib\site-packages\_pytest\runner.py:226: in from_call
    result = func()
c:\python27\lib\site-packages\_pytest\runner.py:289: in <lambda>
    call = CallInfo.from_call(lambda: list(collector.collect()), "collect")
c:\python27\lib\site-packages\_pytest\python.py:655: in collect
    for x in self._collectfile(path):
c:\python27\lib\site-packages\_pytest\python.py:606: in _collectfile
    path.islink(),
E   AssertionError: local('C:\\projects\\gdal\\autotest\\pyscripts\\data\\??') is not a file (isdir=False, exists=False, islink=False)

It turns out that this '??' file is the autotest/pyscripts/data/漢字/ directory that couldn't be transcripted to the Windows filesystem encoding while checking out from git

@blueyed
Copy link
Contributor Author

blueyed commented Feb 13, 2019

@rouault
Thanks!

So I think the fix and the more verbose assertion is fine. Integrated in #4784.

@blueyed blueyed closed this Feb 13, 2019
@blueyed blueyed deleted the assert branch February 13, 2019 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants