-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[4.6] Improve output when parsing an ini configuration fails (#5650) #5652
[4.6] Improve output when parsing an ini configuration fails (#5650) #5652
Conversation
Improve output when parsing an ini configuration fails
@RonnyPfannschmidt, any hints why
|
the failure here is weird, did travis not fetch tags properly (or are there too many commits for setuptools-scm to find a closest?) |
Related: pypa/setuptools-scm@2555a9f (but not released) - shows what it does though. |
@nicoddemus i vaugely recall travis adds only about 50 commits by default, which is a problem in some cases like this one |
https://travis-ci.org/pytest-dev/pytest/jobs/562618711#L160 <- depth of 50 - its lacking, i recall that travis has no describe equivalent so we are in a blind here |
@nicoddemus i believe setting https://docs.travis-ci.com/user/customizing-the-build/#git-clone-depth will help |
Codecov Report
@@ Coverage Diff @@
## 4.6-maintenance #5652 +/- ##
===================================================
+ Coverage 95.91% 96.19% +0.28%
===================================================
Files 115 115
Lines 26504 26512 +8
Branches 2613 2613
===================================================
+ Hits 25420 25502 +82
+ Misses 757 704 -53
+ Partials 327 306 -21
Continue to review full report at Codecov.
|
Done, if that works, we should cherry-pick it to |
SIGH |
setuptools-scm needs all tags to guess the version correctly
db452b4
to
2e345fd
Compare
that's pretty unfortunate :/ though, I wonder the trade off on how much time shallow cloning saves vs the features setuptools-scm gives us (I'm not familiar with them enough to make a call here) |
How much time does shallow cloning saves us?
|
@@ -13,6 +13,10 @@ env: | |||
global: | |||
- PYTEST_ADDOPTS=-vv | |||
|
|||
# setuptools-scm needs all tags in order to obtain a proper version | |||
git: | |||
depth: false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could still limit it to 1000.
The default is 50.
Having additional merge commits for single commit changes (or even 5+ "updated X" commits for what should be a single commit, because you cannot easily squash-merge certainly does not help here ;))
But to be fair: for a stable branch it is easy to get away 50+ commits anyway.
FWIW I find https://github.com/zsimic/setupmeta/ to be even greater (with the same limitations here probably though). |
Backport of #5650