Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make minor grammar changes in doctest.rst #7828

Merged
merged 1 commit into from
Oct 2, 2020

Conversation

mvoitko
Copy link
Contributor

@mvoitko mvoitko commented Oct 2, 2020

No description provided.

@Zac-HD
Copy link
Member

Zac-HD commented Oct 2, 2020

"adding commas" is not "fixing typos", and while we welcome Hacktoberfest contributions this is not actually helpful.

@Zac-HD Zac-HD closed this Oct 2, 2020
@Zac-HD Zac-HD added the invalid label Oct 2, 2020
@pytest-dev pytest-dev locked as off-topic and limited conversation to collaborators Oct 2, 2020
@The-Compiler
Copy link
Member

@Zac-HD This seems unnecessarily dismissive, IMHO. While Hacktoberfest-spam is a problem, I view this PR as a net-positive.

Also, it's coming from a GitHub account which exists for a long time already, so this doesn't seem like someone just trying to game the system for getting a t-shirt. It really doesn't sit well with me to outright dismiss well-intended contributions just because they're a minor change and it happens to be October. This is how you drive new contributors away.

Note that "typos" vs. "grammar changes" is a subtle distinction, even more so for someone who (presumably) isn't a native English speaker.

Taking the freedom to reopen and merge this.

@The-Compiler The-Compiler reopened this Oct 2, 2020
@pytest-dev pytest-dev unlocked this conversation Oct 2, 2020
@Zac-HD
Copy link
Member

Zac-HD commented Oct 2, 2020

Apologies @mvoitko, I guess I'm a little over-sensitised 😕

(and thanks for catching it, @The-Compiler)

@mvoitko mvoitko changed the title Fix minor typos in doctest.rst Make minor grammar changes in doctest.rst Oct 2, 2020
@mvoitko
Copy link
Contributor Author

mvoitko commented Oct 2, 2020

@The-Compiler @Zac-HD Thanks a lot. I was searching for a starting point to contribute to pytest since I have been using it for a very long time and notices these very minor grammar issues. (I am not a native English speaker) I would appreciate it if you could suggest a good first PR issue in pytest.

@Zac-HD
Copy link
Member

Zac-HD commented Oct 2, 2020

Checking issues labelled easy, #3141 might be good 🙂

@The-Compiler The-Compiler merged commit cb0a13a into pytest-dev:master Oct 2, 2020
@The-Compiler
Copy link
Member

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants