Change deprecation warnings into errors for 7.0 release

[nicoddemus]

Fix #7363
Close #8833

[The-Compiler]

Ah, I see - but with this, I suppose some of my suggestions for moving things from 7.0 to 8.0 in #8834 and #8826 are actually wrong? Could you please take a look at those?

[The-Compiler]

Oh, also, how does this work with warnings which weren't part of 6.3.0, but only introduced in this release? Looking at deprecated.py and the changelogs we seem to have many new deprecations which haven't been in a release yet?

[nicoddemus]

Ah, I see - but with this, I suppose some of my suggestions for moving things from 7.0 to 8.0 in #8834 and #8826 are actually wrong? Could you please take a look at those?

Yes, those all should be changed back to 7.0, as that's when they turned into errors. (see below)

Looking at deprecated.py and the changelogs we seem to have many new deprecations which haven't been in a release yet?

Bummer, yes you are right. Unfortunately we took so long to make a new release (with things landing on main meanwhile) that we are not following through with our policy of showing deprecations for two minor releases before turning them into errors.

1. We revert the deprecations altogether?
2. We don't turn those warnings into errors for 7.0, instead postponing that to 8.0?

I think 2) is the simplest one (much less work), and it just means some warnings will be visible longer, which I think is preferable than turning them into errors right away. In practice it just means closing this PR and scheduling the related issues to 8.0.

@RonnyPfannschmidt @bluetech @asottile what do you guys think?

[bluetech]

I'd go with 2 -- no reason to revert them, can just not turn them into errors.

[The-Compiler]

I'd prefer 2 as well, especially because this major release is a bit special - it's only really a major release because of how much stuff accumulated. I'd rather keep 7.0 a rather painless release for people (reducing the pain to whatever will perhaps surface due to all our internal changes), and have the intended breakage in a 8.0 where we are a bit more flexible and hopefully not as pressured by not having had a release in a long time.

[nicoddemus]

Great, closing this then! I have updated the other issues as appropriate. 👍