-
-
Notifications
You must be signed in to change notification settings - Fork 2.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the CodeCov GitHub Action instead of the Bash Uploader #9204
Conversation
The upload script also transforms the binary coverage data to a coverage xml report That command would have to be executed |
Is this coverage xml report also uploaded to CodeCov? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for working on this @mPandaRed. There's still some work needed; when it works, you should see the coverage reported for the PR.
run: bash scripts/upload-coverage.sh -F GHA,${{ runner.os }} | ||
uses: codecov/codecov-action@v2 | ||
with: | ||
files: ./.coverage,./coverage.xml |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think only the XML is relevant here, so you should remove the first one.
Also, you need to generate coverage.xml
, it is not generated automatically. See here.
Finally, if you decide to no longer use the scripts/upload-coverage.sh
script, you should remove it from git.
The fix has been merged in #9252. Thanks anyway! |
Closes #9202
Using the new GitHub Action for CodeCov to upload the code coverage report instead of the bash uploader.
https://github.com/marketplace/actions/codecov