-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add a FAQ #242
add a FAQ #242
Conversation
50f49f4
to
994633d
Compare
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
=========================================
Coverage ? 79.52%
=========================================
Files ? 32
Lines ? 4401
Branches ? 810
=========================================
Hits ? 3500
Misses ? 776
Partials ? 125 Continue to review full report at Codecov.
|
@basnijholt what's the status of this? |
Waiting on review and some answers. We could merge without the unanswered questions though. |
OK. I'll put this on my review backlog |
Co-Authored-By: Joseph Weston <[email protected]>
Co-Authored-By: Joseph Weston <[email protected]>
Co-Authored-By: Joseph Weston <[email protected]>
Co-Authored-By: Joseph Weston <[email protected]>
Co-authored-by: Joseph Weston <[email protected]>
I've enabled auto-merge on this PR and commented out the unanswered questions. |
Codecov Report
@@ Coverage Diff @@
## master #242 +/- ##
==========================================
+ Coverage 80.46% 80.53% +0.06%
==========================================
Files 35 35
Lines 4653 4654 +1
Branches 838 838
==========================================
+ Hits 3744 3748 +4
+ Misses 783 782 -1
+ Partials 126 124 -2
Continue to review full report at Codecov.
|
@jbweston and @akhmerov, feel free to edit and add answers and questions.