Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a FAQ #242

Merged
merged 13 commits into from
Aug 22, 2021
Merged

add a FAQ #242

merged 13 commits into from
Aug 22, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Dec 14, 2019

@jbweston and @akhmerov, feel free to edit and add answers and questions.

@basnijholt basnijholt force-pushed the add-faq branch 5 times, most recently from 50f49f4 to 994633d Compare December 14, 2019 18:10
docs/source/faq.rst Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
docs/source/faq.rst Outdated Show resolved Hide resolved
example-notebook.ipynb Outdated Show resolved Hide resolved
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ad54a7e). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #242   +/-   ##
=========================================
  Coverage          ?   79.52%           
=========================================
  Files             ?       32           
  Lines             ?     4401           
  Branches          ?      810           
=========================================
  Hits              ?     3500           
  Misses            ?      776           
  Partials          ?      125

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad54a7e...3eb0618. Read the comment docs.

@jbweston
Copy link
Contributor

@basnijholt what's the status of this?

@basnijholt
Copy link
Member Author

Waiting on review and some answers. We could merge without the unanswered questions though.

@jbweston
Copy link
Contributor

Waiting on review and some answers. We could merge without the unanswered questions though.

OK. I'll put this on my review backlog

@basnijholt basnijholt changed the title WIP: add a FAQ add a FAQ Aug 21, 2021
@basnijholt basnijholt enabled auto-merge August 21, 2021 10:08
@basnijholt
Copy link
Member Author

I've enabled auto-merge on this PR and commented out the unanswered questions.

@codecov-commenter
Copy link

codecov-commenter commented Aug 21, 2021

Codecov Report

Merging #242 (fee07a6) into master (4e34aba) will increase coverage by 0.06%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #242      +/-   ##
==========================================
+ Coverage   80.46%   80.53%   +0.06%     
==========================================
  Files          35       35              
  Lines        4653     4654       +1     
  Branches      838      838              
==========================================
+ Hits         3744     3748       +4     
+ Misses        783      782       -1     
+ Partials      126      124       -2     
Impacted Files Coverage Δ
adaptive/tests/test_learner1d.py 94.77% <100.00%> (+0.02%) ⬆️
adaptive/learner/learner1D.py 89.74% <0.00%> (+0.28%) ⬆️
adaptive/runner.py 71.73% <0.00%> (+0.70%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4e34aba...fee07a6. Read the comment docs.

@basnijholt basnijholt merged commit c24d5a5 into master Aug 22, 2021
@basnijholt basnijholt deleted the add-faq branch August 22, 2021 19:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants