Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minimally require ipyparallel 6.2.5 #270

Merged
merged 1 commit into from
Apr 22, 2020
Merged

minimally require ipyparallel 6.2.5 #270

merged 1 commit into from
Apr 22, 2020

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Apr 20, 2020

Description

This means that we won't run into joblib/loky#240

This can be merged when ipyparallel 6.2.5 is on conda-forge.
On conda-forge now: conda-forge/ipyparallel-feedstock#48

Fixes #249.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

This means that we won't run into joblib/loky#240
@akhmerov
Copy link
Contributor

Not sure it's appropriate: the problem is only there in python 3.8.

@basnijholt
Copy link
Member Author

basnijholt commented Apr 20, 2020

I think we really need this because whenever someone installed ipyparallel on Python 3.8, Adaptive's default scheduler (loky) is broken: joblib/loky#240.

I spoke with @jbweston and he also agreed.

Copy link
Contributor

@jbweston jbweston left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine.

I would rather prioritize things "just working" on as wide a range of installs as possible, rather than requiring only the minimum version of everything.

@akhmerov
Copy link
Contributor

Why do tests fail 🤔

@basnijholt
Copy link
Member Author

Why do tests fail 🤔

@akhmerov, this is unrelated, the test is just flaky (which we should fix).

@basnijholt basnijholt merged commit a0b22ff into master Apr 22, 2020
@basnijholt basnijholt mentioned this pull request May 19, 2020
@basnijholt basnijholt deleted the ipyparallel-6.2.5 branch May 20, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ipyparallel fails in Python 3.8
3 participants