Learner1D: return inf loss when the bounds aren't done #271
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
@bernardvanheck found an issue that occurs when using multiple cores on the following function
Here the middle region is exponentially flat and the blue curve is a homogeneous plot and the orange points are of the finished learner with a very small loss (<0.01).
I think that a learner should report an infinite loss whenever the bounds aren't included.
Having that, means that the issue I described above is much less likely to occur.
The following code snippet results in a learner with a small loss after only 3 points.
Checklist
pre-commit run --all
(first install usingpip install pre-commit
)pytest
passedType of change
Check relevant option(s).