Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

AverageLearner: implement min_npoints #274

Merged
merged 7 commits into from
May 14, 2020
Merged

AverageLearner: implement min_npoints #274

merged 7 commits into from
May 14, 2020

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented May 14, 2020 •
edited
Loading

Description

Adds min_npoints as a parameter to the AverageLearner.

Closes #273

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@basnijholt basnijholt requested a review from akhmerov May 14, 2020 11:59
@basnijholt basnijholt force-pushed the feature/min_npoints branch from f586e5d to 52a7252 Compare May 14, 2020 13:46
@akhmerov
Copy link
Contributor

Thanks, LGTM now.

@basnijholt basnijholt merged commit 1c60897 into master May 14, 2020
@basnijholt basnijholt mentioned this pull request May 19, 2020
Closed
@basnijholt basnijholt deleted the feature/min_npoints branch May 20, 2020 08:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhmerov akhmerov akhmerov left review comments

Assignees
No one assigned
Labels
AverageLearner enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

add minimum number of points parameter to AverageLearner
2 participants
@basnijholt @akhmerov