Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make loky a default on Windows and MacOS but not on Linux #300

Merged
merged 4 commits into from
Mar 5, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Mar 5, 2021

Description

Make loky a default on Windows and MacOS but not on Linux.

I am doing this because several people have indicated that they are experiencing issues with Loky on a Linux cluster.
On Windows and MacOS loky is preferred because ProcessPoolExecutor won't work in interactive environments.

Closes #301

See also

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

@akhmerov
Copy link
Contributor

akhmerov commented Mar 5, 2021

Sounds good to me.

@codecov-io
Copy link

Codecov Report

Merging #300 (9e0dad9) into master (75a3274) will increase coverage by 0.08%.
The diff coverage is 70.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #300      +/-   ##
==========================================
+ Coverage   80.61%   80.70%   +0.08%     
==========================================
  Files          35       35              
  Lines        4623     4623              
  Branches      831      832       +1     
==========================================
+ Hits         3727     3731       +4     
+ Misses        771      768       -3     
+ Partials      125      124       -1     
Impacted Files Coverage Δ
adaptive/runner.py 71.53% <66.66%> (+0.96%) ⬆️
adaptive/tests/test_runner.py 95.00% <71.42%> (+0.06%) ⬆️
adaptive/tests/test_cquad.py 92.25% <0.00%> (+0.64%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 75a3274...9e0dad9. Read the comment docs.

@basnijholt basnijholt merged commit ae2ddf4 into master Mar 5, 2021
@basnijholt basnijholt deleted the loky-non-default branch March 7, 2021 14:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ProcessPoolExecutor behaviour on MacOS in interactive environment changed between Python versions
3 participants