Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add resolution_loss_function for Learner1D #310

Merged
merged 2 commits into from
Mar 18, 2021
Merged

add resolution_loss_function for Learner1D #310

merged 2 commits into from
Mar 18, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Mar 18, 2021 •
edited
Loading

Description

add resolution_loss_function for Learner1D like we have for the Learner2D.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

akhmerov
akhmerov approved these changes Mar 18, 2021
View reviewed changes
Copy link
Contributor

@akhmerov akhmerov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sounds good

@basnijholt basnijholt enabled auto-merge March 18, 2021 17:03
@basnijholt basnijholt disabled auto-merge March 18, 2021 17:28
@basnijholt basnijholt merged commit 2d0444b into master Mar 18, 2021
@basnijholt basnijholt deleted the resolution-loss-1d branch March 18, 2021 17:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akhmerov akhmerov akhmerov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@basnijholt @akhmerov