Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an animated logo that shows the working of Adaptive #329

Merged
merged 13 commits into from
Sep 23, 2021

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Sep 23, 2021

Description

Adds a fancy moving logo at a minimal cost of 300 KB.

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

@basnijholt basnijholt changed the title Feat/animated logo Add an animated logo that shows the working of Adaptive Sep 23, 2021
@codecov-commenter
Copy link

Codecov Report

Merging #329 (e7e514e) into master (0a14a9e) will decrease coverage by 0.11%.
The diff coverage is n/a.

❗ Current head e7e514e differs from pull request most recent head d9395e3. Consider uploading reports for the commit d9395e3 to get more accurate results
Impacted file tree graph

@@            Coverage Diff             @@
##           master     #329      +/-   ##
==========================================
- Coverage   80.87%   80.75%   -0.12%     
==========================================
  Files          38       38              
  Lines        5051     5051              
  Branches      916      916              
==========================================
- Hits         4085     4079       -6     
- Misses        826      829       +3     
- Partials      140      143       +3     
Impacted Files Coverage Δ
adaptive/learner/average_learner1D.py 78.88% <0.00%> (-0.75%) ⬇️
adaptive/runner.py 71.02% <0.00%> (-0.71%) ⬇️
adaptive/learner/learner1D.py 89.62% <0.00%> (-0.54%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0a14a9e...d9395e3. Read the comment docs.

@basnijholt basnijholt force-pushed the feat/animated-logo branch 2 times, most recently from b053507 to 9417b05 Compare September 23, 2021 17:44
@akhmerov
Copy link
Contributor

Why not generate this in jupyter-sphinx instead of creating a separate directive?

@basnijholt
Copy link
Member Author

That is also an option, but I think it would clutter the README.rst file more than this.

@akhmerov
Copy link
Contributor

IIRC jupyter-sphinx directives allow to link a file to read from.

@basnijholt basnijholt merged commit 4507195 into master Sep 23, 2021
@basnijholt basnijholt deleted the feat/animated-logo branch September 23, 2021 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants