Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use nb_execution_raise_on_error Sphinx myst-nb option #396

Merged
merged 6 commits into from
Apr 7, 2023

Conversation

basnijholt
Copy link
Member

@basnijholt basnijholt commented Jan 10, 2023

The option nb_execution_fail_on_error does not exist.

Description

Please include a summary of the change and which (if so) issue is fixed.

Fixes #(ISSUE_NUMBER_HERE)

Checklist

  • Fixed style issues using pre-commit run --all (first install using pip install pre-commit)
  • pytest passed

Type of change

Check relevant option(s).

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • (Code) style fix or documentation update
  • This change requires a documentation update

The option nb_execution_fail_on_error does not exist.
@basnijholt basnijholt enabled auto-merge (squash) January 10, 2023 17:31
@codecov-commenter
Copy link

Codecov Report

Merging #396 (ef05f37) into main (01569d2) will decrease coverage by 0.04%.
The diff coverage is n/a.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #396      +/-   ##
==========================================
- Coverage   78.07%   78.04%   -0.04%     
==========================================
  Files          38       38              
  Lines        5529     5529              
  Branches      989      989              
==========================================
- Hits         4317     4315       -2     
- Misses       1059     1060       +1     
- Partials      153      154       +1     

see 1 file with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@basnijholt basnijholt disabled auto-merge April 7, 2023 19:59
@basnijholt basnijholt merged commit 81464a3 into main Apr 7, 2023
@basnijholt basnijholt deleted the fix-myst-nb-fail branch April 7, 2023 19:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants