Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python 3.7 warnings #607

Closed
tirkarthi opened this issue Oct 25, 2018 · 6 comments
Closed

Python 3.7 warnings #607

tirkarthi opened this issue Oct 25, 2018 · 6 comments

Comments

@tirkarthi
Copy link

Python 3.7 introduced a warning with respect to collections that will be removed in 3.8 making the project incompatible with 3.8.

Found at https://travis-ci.org/python/cpython/jobs/446051148#L2596

/home/travis/build/python/cpython/Doc/venv/lib/python3.8/site-packages/pkg_resources/_vendor/pyparsing.py:3226: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

Sample fix : pallets/markupsafe#98

@akx
Copy link
Member

akx commented Oct 25, 2018

The warning seems to originate from pkg_resources's vendored version of pyparsing.
pkg_resources is not a dependency of Babel's, so this is probably not a Babel bug.

Closing, but please let me know if I'm wrong!

@akx akx closed this as completed Oct 25, 2018
@tirkarthi
Copy link
Author

Sorry, my bad I copy pasted the wrong line for reference. Please find the actual warning as below. I checked master and the line is still present so the warning is valid. I would request reopening this.

/home/travis/build/python/cpython/Doc/venv/lib/python3.8/site-packages/babel/localedata.py:17: DeprecationWarning: Using or importing the ABCs from 'collections' instead of from 'collections.abc' is deprecated, and in 3.8 it will stop working

@akx
Copy link
Member

akx commented Oct 25, 2018

Ah, that's more like it then. Reopening :)

@akx akx reopened this Oct 25, 2018
@tirkarthi
Copy link
Author

tirkarthi commented Oct 25, 2018

Thanks, I guess it's the only place. I will grep for similar places if any and raise a PR. Also adding 3.7 to Travis might help which I can add as part of the same PR if it's ok.

@akx
Copy link
Member

akx commented Oct 25, 2018

Please do! :)

@tirkarthi
Copy link
Author

Fixed with #609 closing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants