Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix DeprecationWarning in 3.7 #608

Closed
wants to merge 2 commits into from
Closed

Fix DeprecationWarning in 3.7 #608

wants to merge 2 commits into from

Conversation

tirkarthi
Copy link

  • This PR fixes the deprecation warnings in 3.7
  • Upgrade freezegun to support 3.7. Current version is incompatible with 3.7 so I have upgraded it (Reference : 3.7 support (uuid module changes) spulec/freezegun#231)
  • Grepping for similar imports doesn't show up any places related to this

Successful build : https://travis-ci.org/tirkarthi/babel/builds/446248386

I added 3.7 but it seems Travis has problems with 3.7 and Ubuntu 14.04 so I have reverted it. Since the CI passes on 3.6 and 2.7 I think it's safe to merge. I cannot verify them locally due to setting up locales and test data in my Ubuntu machine.

Travis issue : travis-ci/travis-ci#9815
Python 3.7 and Ubuntu 14.04 issue : travis-ci/travis-ci#9069

closes #607

Friendly ping @akx

Thanks

@codecov-io
Copy link

codecov-io commented Oct 25, 2018

Codecov Report

Merging #608 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #608      +/-   ##
==========================================
+ Coverage   90.31%   90.31%   +<.01%     
==========================================
  Files          24       24              
  Lines        4128     4130       +2     
==========================================
+ Hits         3728     3730       +2     
  Misses        400      400
Impacted Files Coverage Δ
babel/_compat.py 98.14% <100%> (+0.1%) ⬆️
babel/localedata.py 95.41% <100%> (-0.05%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2cf189...49b75c4. Read the comment docs.

@tirkarthi
Copy link
Author

Closing since #609 was merged

@tirkarthi tirkarthi closed this Nov 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Python 3.7 warnings
2 participants