Remove now-obsolete NativeIO shim. #113
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only needed for Python 2 compatibility, which was dropped in v1.16.0.
|
I'm not too keen on this kind of breaking change with no real purpose. It would be cool if I, for example, could still download the latest version and run it in python 2.7 with minimal fixes, and I know other people like me. |
|
Can you run it on 2.7, though? setup.py says the minimum python version is 3.8, and has done since v1.16.0 |
|
Huh, I guess it does work on 2.7. Pip won't install it, but if you download the tarball and run setup.py it will happily install (although |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was only needed for Python 2 compatibility, which was dropped in v1.16.0.